Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointer): fire pointer events on disabled elements #818

Merged
merged 2 commits into from
Jan 1, 2022
Merged

Conversation

ph-fritsche
Copy link
Member

What:

Fire pointer events when clicking disabled input elements.

Why:

Closes #804

Checklist:

  • Tests
  • Ready to be merged

@ph-fritsche ph-fritsche added this to the userEvent v14 milestone Dec 29, 2021
@ph-fritsche ph-fritsche linked an issue Dec 29, 2021 that may be closed by this pull request
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 29, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c1ef55:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #818 (3c1ef55) into beta (2c5d9f1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              beta      #818   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           77        79    +2     
  Lines         1572      1578    +6     
  Branches       557       559    +2     
=========================================
+ Hits          1572      1578    +6     
Impacted Files Coverage Δ
src/pointer/pointerPress.ts 100.00% <100.00%> (ø)
src/keyboard/plugins/index.ts 100.00% <0.00%> (ø)
src/keyboard/keyboardAction.ts 100.00% <0.00%> (ø)
src/keyboard/plugins/functional.ts 100.00% <0.00%> (ø)
src/utils/dataTransfer/Clipboard.ts 100.00% <0.00%> (ø)
src/utils/keyDef/readNextDescriptor.ts 100.00% <0.00%> (ø)
src/utils/pointer/firePointerEvents.ts 100.00% <0.00%> (ø)
src/keyboard/getEventProps.ts
src/keyboard/plugins/modifiers.ts 100.00% <0.00%> (ø)
src/utils/keyboard/getKeyEventProps.ts 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c5d9f1...3c1ef55. Read the comment docs.

@ph-fritsche ph-fritsche merged commit ef2f4e5 into beta Jan 1, 2022
@ph-fritsche ph-fritsche deleted the fix-804 branch January 1, 2022 19:59
@github-actions
Copy link

github-actions bot commented Jan 1, 2022

🎉 This PR is included in version 14.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger pointerdown and pointerup on disabled elements
1 participant